Skip to content

Add stable url, tag and revision to json output#6992

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
igas:url-in-json
Feb 2, 2020
Merged

Add stable url, tag and revision to json output#6992
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
igas:url-in-json

Conversation

@igas
Copy link
Copy Markdown

@igas igas commented Feb 2, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Currently, we only have versions in the output. For introspection/integration reasons it'll be useful to have urls too.

Comment thread Library/Homebrew/formula.rb Outdated
@igas igas requested a review from MikeMcQuaid February 2, 2020 16:13
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ❤️

@MikeMcQuaid MikeMcQuaid merged commit a55454d into Homebrew:master Feb 2, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @igas!

@igas igas deleted the url-in-json branch February 2, 2020 17:28
@lock lock bot added the outdated PR was locked due to age label Mar 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants