brew reinstall --interactive

[sj26]

More often than I realised, I want to brew reinstall --build-from-source --interactive $FORMULA to add some custom configuration. It seems like a useful addition?

[MikeMcQuaid]

@Homebrew/maintainers would any of you use this?

[claui]

As a workaround, I’ve always used the following kludge:

brew uninstall $FORMULA; brew install --build-from-source --interactive $FORMULA

and I’d be more than delighted to have this feature.

[SMillerDev]

I don't care specifically about interactive but I'm very much in favor of install and reinstall behaving the same.

[jonchang]

Yes, I think that brew install and brew reinstall should have the same interface.

[igas]

When I bump formula and it fails locally, for debug purposes I use similar to @claui approach.

[EricFromCanada]

It would also be useful to have --HEAD available, as it's a quick way of seeing if a bug in a released version has been fixed by a newer commit.

[MikeMcQuaid]

I don't think it's worth making the interface identical because not all options make sense for reinstall. I'm game to add options as requested but let's not add them all en-masse (install has a lot).

[MikeMcQuaid]

Thanks for the PR! You will also need to brew man and commit the changes.

[MikeMcQuaid]

Suggested change

	reinstall_formula(f) do |fi|
	reinstall_formula(f, interactive: args.interactive?)

[sj26]

Nice suggestion!

I wasn't sure what to do here — deep inside reinstall_formula uses ARGV.interactive? so perhaps just adding the flag to the listed flags in cmd/reinstall is enough, and remove the yield? I notice reinstall_formula is only otherwise used in cmd/upgrade which also does not list --interactive.

[sj26]

Yeah, just listing the switch in the switches is enough to make it work. I'll back out the rest.

[MikeMcQuaid]

Sounds good!

[MikeMcQuaid]

Suggested change

yield fi if block_given?

[MikeMcQuaid]

Suggested change

fi.interactive = args.interactive?

[MikeMcQuaid]

Suggested change

end

[MikeMcQuaid]

It would also be useful to have --HEAD available, as it's a quick way of seeing if a bug in a released version has been fixed by a newer commit.

I think brew upgrade --HEAD would be make more logical sense here. If that doesn't already work: would accept PR for that!

[sj26]

I think brew upgrade --HEAD would be make more logical sense here. If that doesn't already work: would accept PR for that!

Does brew upgrade --fetch-HEAD $FORMULA already do the job?

Edit: Oh, no, I see — upgrading from non-HEAD to HEAD.

[MikeMcQuaid]

Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @sj26!