Skip to content

deps: give consistent results#7025

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dawidd6:deps-tree-consistent
Feb 13, 2020
Merged

deps: give consistent results#7025
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dawidd6:deps-tree-consistent

Conversation

@dawidd6
Copy link
Copy Markdown
Contributor

@dawidd6 dawidd6 commented Feb 12, 2020

brew deps and brew deps --tree might give inconsistent results if
installed formula is older than the one available in tap.
This commit fixes it.

Closes: #7016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Comment thread Library/Homebrew/cmd/deps.rb Outdated
@dawidd6 dawidd6 force-pushed the deps-tree-consistent branch from 09c1366 to e3e49d1 Compare February 12, 2020 21:30
Comment thread Library/Homebrew/cmd/deps.rb Outdated
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
@dawidd6 dawidd6 force-pushed the deps-tree-consistent branch from f820889 to 967b9b8 Compare February 12, 2020 21:38
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here, thanks again @dawidd6!

@MikeMcQuaid MikeMcQuaid merged commit 1b2bb23 into Homebrew:master Feb 13, 2020
@dawidd6 dawidd6 deleted the deps-tree-consistent branch February 13, 2020 11:24
@lock lock bot added the outdated PR was locked due to age label Mar 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew deps produces different output when used with --tree option

2 participants