feat: expose casks in tap.to_hash for tap-info --json#7043
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Feb 18, 2020
Merged
feat: expose casks in tap.to_hash for tap-info --json#7043MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Conversation
Contributor
Author
|
and as far as tests go, a lot of unrelated tests were failing, and it looks like the only test for |
Member
|
Thanks for the PR! Seems reasonable to be but interested in @EricFromCanada and @reitermarkus' thoughts. |
Member
EricFromCanada
left a comment
There was a problem hiding this comment.
Since a list of formula_names is defined, I think cask_tokens should be provided as well.
Member
|
Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @forivall! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?Hey yall. I wanted to install [meme] all the fonts [/meme] from homebrew-cask-fonts (well, i really want to generate specimens for all of them so i can find a font that looks like the ✨ aesthetic ✨ i'm looking for, but that's a larger change and my ruby experience is minimal), and so i wanted to see all of the casks it provides, and adding it to the hash seems like the correct place, as
formula_filesandcommand_filesare there.With this, I was able to complete my task with
brew tap-info homebrew/homebrew-cask-fonts --json|jq -r '.[] | .cask_files[]' | sed -e 's|.*/||' -e 's/\.rb$//' | xargs brew cask install.