Skip to content

test: set Git name and email.#7046

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:set_git_name_email
Feb 17, 2020
Merged

test: set Git name and email.#7046
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:set_git_name_email

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

Extract the code from bottle.rb into utils/git.rb and ensure it's run before we run tests.

Should resolve issues like in Homebrew/homebrew-core#50328

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Extract the code from `bottle.rb` into `utils/git.rb` and ensure it's
run before we run tests.

Should resolve issues like in
Homebrew/homebrew-core#50328
@MikeMcQuaid MikeMcQuaid merged commit 7ca8a52 into Homebrew:master Feb 17, 2020
@MikeMcQuaid MikeMcQuaid deleted the set_git_name_email branch February 17, 2020 20:29
@lock lock bot added the outdated PR was locked due to age label Mar 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant