docs(Shell-Completion.md): modified conditional for .zshrc to include…#7065
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Feb 22, 2020
Merged
Conversation
… call to compinit
MikeMcQuaid
approved these changes
Feb 22, 2020
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Makes sense to me!
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @kreig303!
This was referenced Feb 22, 2020
Contributor
Author
|
nw @MikeMcQuaid i know it's not a major change but there's a fixed overhead to each & every issue+pr so hth! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… call to
compinitn/a Have you written new tests for your changes? Here's an example.
brew stylewith your changes locally?brew testswith your changes locally?cf. #7059 for a complete description.
Essentially need to add two lines to the
if fistatement for adding to the.zshrcto ensurecompinitis loaded and available.