Skip to content

docs(Shell-Completion.md): modified conditional for .zshrc to include…#7065

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
kreig303:docs-zshrc-7059-compinit
Feb 22, 2020
Merged

docs(Shell-Completion.md): modified conditional for .zshrc to include…#7065
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
kreig303:docs-zshrc-7059-compinit

Conversation

@kreig303
Copy link
Copy Markdown
Contributor

… call to compinit

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
    n/a Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

cf. #7059 for a complete description.

Essentially need to add two lines to the if fi statement for adding to the .zshrc to ensure compinit is loaded and available.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @kreig303!

@kreig303
Copy link
Copy Markdown
Contributor Author

nw @MikeMcQuaid

i know it's not a major change but there's a fixed overhead to each & every issue+pr so hth!

@lock lock bot added the outdated PR was locked due to age label Mar 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants