analytics: tweak behaviour.#7069
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Feb 23, 2020
MikeMcQuaid:analytics-tweaks
Merged
analytics: tweak behaviour.#7069MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:analytics-tweaks
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:analytics-tweaks
Conversation
- Use separate method for `not_this_run?` so we can still set the analytics message as seen when set. - Clarify when analytics message is printed that we haven't sent any analytics yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use separate method for
not_this_run?so we can still set the analytics message as seen when set.Clarify when analytics message is printed that we haven't sent any analytics yet.
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run
brew stylewith your changes locally?Have you successfully run
brew testswith your changes locally?