Skip to content

version: parse tag if detecting version#7088

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:version
Feb 27, 2020
Merged

version: parse tag if detecting version#7088
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:version

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

@SeekingMeaning SeekingMeaning commented Feb 27, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes detecting the version from a tag such as v1.2.3-beta1 as 1.2.3 when it should be 1.2.3-beta1

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks again @SeekingMeaning!

@MikeMcQuaid MikeMcQuaid merged commit f37cd18 into Homebrew:master Feb 27, 2020
@SeekingMeaning SeekingMeaning deleted the version branch February 27, 2020 19:30
@lock lock bot added the outdated PR was locked due to age label Apr 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants