Skip to content

bump-formula-pr: return remote url with token in it#7092

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dawidd6:bump-push-with-token
Mar 2, 2020
Merged

bump-formula-pr: return remote url with token in it#7092
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dawidd6:bump-push-with-token

Conversation

@dawidd6
Copy link
Copy Markdown
Contributor

@dawidd6 dawidd6 commented Feb 29, 2020

Might be useful to be able to push to remote using only the token.
For example on CI.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@dawidd6 dawidd6 force-pushed the bump-push-with-token branch from 4d4b9df to d442ae4 Compare February 29, 2020 00:26
@MikeMcQuaid
Copy link
Copy Markdown
Member

Might be useful to be able to push to remote using only the token.
For example on CI.

Can you provide a bit more of an example of this? Thanks!

Comment thread Library/Homebrew/dev-cmd/bump-formula-pr.rb Outdated
@dawidd6
Copy link
Copy Markdown
Contributor Author

dawidd6 commented Mar 2, 2020

On CI one would not need to set up a ssh key to be able to push the branch, but simply just use the token for that, which already has the required scopes.

I'm currently building a Github Action for brew bump-formula-pr and this approach seems to be the best option and it works well.

@MikeMcQuaid
Copy link
Copy Markdown
Member

On CI one would not need to set up a ssh key to be able to push the branch, but simply just use the token for that, which already has the required scopes.

Cool, that sounds good then 👍

@dawidd6 dawidd6 force-pushed the bump-push-with-token branch from d442ae4 to 456f3b1 Compare March 2, 2020 17:50
@dawidd6 dawidd6 requested a review from MikeMcQuaid March 2, 2020 17:51
@MikeMcQuaid MikeMcQuaid merged commit 10ba0d5 into Homebrew:master Mar 2, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @dawidd6!

@dawidd6 dawidd6 deleted the bump-push-with-token branch March 2, 2020 18:44
@lock lock bot added the outdated PR was locked due to age label Apr 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants