Display updated casks when running brew update#7101
Merged
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom Mar 3, 2020
Merged
Display updated casks when running brew update#7101MikeMcQuaid merged 3 commits intoHomebrew:masterfrom
brew update#7101MikeMcQuaid merged 3 commits intoHomebrew:masterfrom
Conversation
MichelleNguy
force-pushed
the
display-updated-casks
branch
from
baf0d7a to
27e4532
Compare
MichelleNguy
force-pushed
the
display-updated-casks
branch
from
27e4532 to
948ad02
Compare
MikeMcQuaid
reviewed
Mar 3, 2020
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks great so far! A few suggest comments.
Contributor
Author
|
Also, any suggestions on meatier issues that need a look? |
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
MichelleNguy
force-pushed
the
display-updated-casks
branch
from
879503a to
352774e
Compare
MikeMcQuaid
approved these changes
Mar 3, 2020
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks great!
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @MichelleNguy!
|
@MichelleNguy Thank you for this. It seemed to work fine for me, except installed casks didn't get highlighted like normal formula do when an update for them is found. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?This pull request adds an additional report for modified casks to the reporter class and also adds the printout to the dump method as requested in issue #7011.
This is my first open source pull request and first pull request on Homebrew. I see what you want tests, but not sure which kind of tests are needed for this. I would love some direction.
Brew tests does not pass locally, but I suspect it will pass on CI. The same tests that are failing now were failing when I started on the feature and I could not figure out how to get them to pass.