Skip to content

Add headers option to URLs in forumlas#7144

Merged
MikeMcQuaid merged 9 commits intoHomebrew:masterfrom
spaceapegames:master
Apr 1, 2020
Merged

Add headers option to URLs in forumlas#7144
MikeMcQuaid merged 9 commits intoHomebrew:masterfrom
spaceapegames:master

Conversation

@ctompkinson
Copy link
Copy Markdown
Contributor

@ctompkinson ctompkinson commented Mar 10, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As raised in #7138 this adds the ability to use two headers when writing formula in case you need both an access key header and an accept header (plus many other fun uses).

Comment thread Library/Homebrew/download_strategy.rb
Comment thread Library/Homebrew/download_strategy.rb Outdated
Comment thread Library/Homebrew/download_strategy.rb Outdated
@MikeMcQuaid MikeMcQuaid merged commit c0dca27 into Homebrew:master Apr 1, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @ctompkinson!

@lock lock bot added the outdated PR was locked due to age label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants