Skip to content

cask-caveats-kext: retry installation if it fails#7207

Merged
vitorgalvao merged 1 commit intoHomebrew:masterfrom
vitorgalvao:kext_caveat
Mar 24, 2020
Merged

cask-caveats-kext: retry installation if it fails#7207
vitorgalvao merged 1 commit intoHomebrew:masterfrom
vitorgalvao:kext_caveat

Conversation

@vitorgalvao
Copy link
Copy Markdown
Contributor

@vitorgalvao vitorgalvao commented Mar 23, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Some installations fail before the user has the chance to allow the kext. Seeing as those are being deprecated, it seems like a waste of resources to invest time on a workaround that likely will fail (there’s a reason we show a message instead).

@vitorgalvao vitorgalvao added the cask Homebrew Cask label Mar 23, 2020
@vitorgalvao vitorgalvao merged commit 7dfd62a into Homebrew:master Mar 24, 2020
@vitorgalvao vitorgalvao deleted the kext_caveat branch March 24, 2020 01:32
@lock lock bot added the outdated PR was locked due to age label Apr 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cask Homebrew Cask outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant