integration_test: only run on system Ruby.#7241
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Mar 31, 2020
MikeMcQuaid:integration_tests_only_system_ruby
Merged
integration_test: only run on system Ruby.#7241MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:integration_tests_only_system_ruby
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:integration_tests_only_system_ruby
Conversation
There appear to be random, seemingly impossible to debug issues with running integration tests on portable Ruby. Instead of confusing contributors when these will be run on CI anyway: let's just skip them by default (like we do with `--online` for online tests anyway).
Member
|
The crash specifically happens when the launched Ruby process launches another Ruby process (e.g. like in |
Member
Author
Good catch, this part is news to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appear to be random, seemingly impossible to debug issues with running integration tests on portable Ruby. Instead of confusing contributors when these will be run on CI anyway: let's just skip them by default (like we do with
--onlinefor online tests anyway).Note to self: ensure that CI is definitely using system Ruby before this is merged...
brew stylewith your changes locally?brew testswith your changes locally?