Skip to content

integration_test: only run on system Ruby.#7241

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:integration_tests_only_system_ruby
Mar 31, 2020
Merged

integration_test: only run on system Ruby.#7241
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:integration_tests_only_system_ruby

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

There appear to be random, seemingly impossible to debug issues with running integration tests on portable Ruby. Instead of confusing contributors when these will be run on CI anyway: let's just skip them by default (like we do with --online for online tests anyway).

Note to self: ensure that CI is definitely using system Ruby before this is merged...

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

There appear to be random, seemingly impossible to debug issues with
running integration tests on portable Ruby. Instead of confusing
contributors when these will be run on CI anyway: let's just skip them
by default (like we do with `--online` for online tests anyway).
@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Mar 31, 2020

The crash specifically happens when the launched Ruby process launches another Ruby process (e.g. like in brew ruby, brew test, brew install etc.) and that Ruby accesses $LOAD_PATH in any manner (Rubygems does $LOAD_PATH.each_with_index but puts $LOAD_PATH also crashes).

@MikeMcQuaid
Copy link
Copy Markdown
Member Author

that Ruby accesses $LOAD_PATH in any manner (Rubygems does $LOAD_PATH.each_with_index but puts $LOAD_PATH also crashes).

Good catch, this part is news to me.

@MikeMcQuaid MikeMcQuaid merged commit 14c8b87 into Homebrew:master Mar 31, 2020
@MikeMcQuaid MikeMcQuaid deleted the integration_tests_only_system_ruby branch March 31, 2020 07:45
@lock lock bot added the outdated PR was locked due to age label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants