Skip to content

pr-publish: make it work on linux too#7244

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dawidd6:pr-publish-linux
Mar 31, 2020
Merged

pr-publish: make it work on linux too#7244
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dawidd6:pr-publish-linux

Conversation

@dawidd6
Copy link
Copy Markdown
Contributor

@dawidd6 dawidd6 commented Mar 31, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

With this patch it becomes possible to successfully use pr-publish command on linux to dispatch the event in homebrew-core repo.

cc @jonchang

Copy link
Copy Markdown
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MikeMcQuaid MikeMcQuaid merged commit 3b4c2ee into Homebrew:master Mar 31, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @dawidd6!

@dawidd6 dawidd6 deleted the pr-publish-linux branch March 31, 2020 08:59
@lock lock bot added the outdated PR was locked due to age label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants