Skip to content

pr-pull: allow to specify tap#7245

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dawidd6:pr-pull-tap
Mar 31, 2020
Merged

pr-pull: allow to specify tap#7245
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dawidd6:pr-pull-tap

Conversation

@dawidd6
Copy link
Copy Markdown
Contributor

@dawidd6 dawidd6 commented Mar 31, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR makes it possible to specify the tap, different than default homebrew/core.

cc @jonchang

@request-info
Copy link
Copy Markdown

request-info bot commented Mar 31, 2020

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Mar 31, 2020
Copy link
Copy Markdown
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MikeMcQuaid MikeMcQuaid merged commit bf74abc into Homebrew:master Mar 31, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @dawidd6!

@dawidd6 dawidd6 deleted the pr-pull-tap branch March 31, 2020 10:54
@dawidd6 dawidd6 restored the pr-pull-tap branch March 31, 2020 10:54
@dawidd6 dawidd6 deleted the pr-pull-tap branch March 31, 2020 10:54
@lock lock bot added the outdated PR was locked due to age label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs response Needs a response from the issue/PR author outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants