load_path: trim entries where possible to fix Ruby crashes

[Bo98]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• :-) Have you successfully run brew tests with your changes locally?

---

[MikeMcQuaid]

Great catch here @Bo98, well done!

[MikeMcQuaid]

A possible extension I was thinking about could be to also trim any paths that don't :exist? or :directory?. Might be overkill, though.

[Bo98]

$LOAD_PATH.select { |d| Pathname(d).exist? } would trim 15 paths on my system, so it might be worth it. Notably it would trim the universal-darwin-19 paths in setup.rb (they are Catalina specific paths) and Ruby's own stuff like site_ruby.

[Bo98]

Those paths should actually be x86_64-darwin13 on everything using portable-ruby because it depends on the OS that Ruby was built on. Fun

[Bo98]

HOMEBREW_LIBRARY_PATH needs to be before the require, but I've simplified the line anyhow and let uniq! handle it.

[MikeMcQuaid]

HOMEBREW_LIBRARY_PATH needs to be before the require, but I've simplified the line anyhow and let uniq! handle it.

Perfect 👍

[MikeMcQuaid]

Thanks again @Bo98!