github: return output if JSON parsing is not desired#7252
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Apr 1, 2020
Merged
github: return output if JSON parsing is not desired#7252MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Conversation
MikeMcQuaid
reviewed
Apr 1, 2020
b7e1660 to
96b059e
Compare
a80cc37 to
c2adfac
Compare
MikeMcQuaid
reviewed
Apr 1, 2020
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Even simpler version suggested
Member
There was a problem hiding this comment.
Suggested change
| parse_json ? json : output | |
| parse_json output |
Contributor
Author
There was a problem hiding this comment.
You meant output only right?
MikeMcQuaid
approved these changes
Apr 1, 2020
Member
|
Looks great, thanks @dawidd6! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are endpoints that do not return a JSON object, like for example:
https://developer.github.com/v3/actions/workflow_runs/#list-workflow-run-logs
Add an option to not parse the response data as JSON.
brew stylewith your changes locally?brew testswith your changes locally?