Skip to content

shims/mac/super/xcrun: use Homebrew's chosen SDK and DEVELOPER_DIR#7255

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:xcrun
Apr 2, 2020
Merged

shims/mac/super/xcrun: use Homebrew's chosen SDK and DEVELOPER_DIR#7255
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:xcrun

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Apr 1, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #7250.

Turns out xcrun is really awkward as it has so many uses. You don't want to set DEVELOPER_DIR all the time because, for example, we have an older compiler in the CLT on Mojave CI nodes - and that compiler might be found via xcrun --find clang.

@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Apr 2, 2020

I'll just pretend I didn't just see Qt's odd use of xcrun --sdk macosx --find clang. I don't think it's worth overcomplicating this for that - if Qt is awkward and chooses the CLT compiler then so be it I say. It won't cause any actual harm and is really not the focus of this fix which is about xcrun --sdk macosx --show-sdk-path.

@MikeMcQuaid MikeMcQuaid merged commit 91223b3 into Homebrew:master Apr 2, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Makes sense, thanks @Bo98!

@Bo98 Bo98 deleted the xcrun branch April 2, 2020 08:53
@lock lock bot added the outdated PR was locked due to age label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xcrun should use Homebrew's choice of SDK

2 participants