formula_cellar_checks: check Python site packages#7261
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Apr 3, 2020
Merged
formula_cellar_checks: check Python site packages#7261MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Conversation
5 tasks
MikeMcQuaid
reviewed
Apr 2, 2020
MikeMcQuaid
approved these changes
Apr 3, 2020
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Few suggested style changes but looks good, thanks again!
MikeMcQuaid
approved these changes
Apr 3, 2020
Member
|
Thanks again @Bo98! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?This audit compares this list to the list of non-recursive dependencies.
Intended behaviours:
When testing, dependencies are not searched recursively. It's difficult to guarantee zero false positives here, particularly if the dependency tree has mixed versions of Python.