Skip to content

formula_cellar_checks: check Python site packages#7261

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:python-linkage
Apr 3, 2020
Merged

formula_cellar_checks: check Python site packages#7261
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:python-linkage

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Apr 2, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This audit compares this list to the list of non-recursive dependencies.

Intended behaviours:

  • Formula depends on python@3.8 and package is installed for Python 3.8 -> pass
    • If there are additional packages for other versions they are ignored. This allows formulae to supply packages for multiple Python versions.
  • Python package for 3.7 installed but depends on python@3.8 -> fail
  • Python package installed but no Python dependencies -> pass
    • Python packages may be an "optional" part of the formula.

When testing, dependencies are not searched recursively. It's difficult to guarantee zero false positives here, particularly if the dependency tree has mixed versions of Python.

Comment thread Library/Homebrew/linkage_checker.rb Outdated
@Bo98 Bo98 force-pushed the python-linkage branch from c2f1d72 to 5e1c7cb Compare April 2, 2020 20:00
@Bo98 Bo98 changed the title linkage_checker: check for Python site packages formula_cellar_checks: check Python site packages Apr 2, 2020
@Bo98 Bo98 force-pushed the python-linkage branch from 5e1c7cb to ea31838 Compare April 3, 2020 00:24
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggested style changes but looks good, thanks again!

Comment thread Library/Homebrew/formula_cellar_checks.rb Outdated
Comment thread Library/Homebrew/formula_cellar_checks.rb Outdated
Comment thread Library/Homebrew/formula_cellar_checks.rb Outdated
Comment thread Library/Homebrew/formula_cellar_checks.rb Outdated
@Bo98 Bo98 force-pushed the python-linkage branch from ea31838 to a298d7d Compare April 3, 2020 08:32
@MikeMcQuaid MikeMcQuaid merged commit 69fbfaa into Homebrew:master Apr 3, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @Bo98!

@Bo98 Bo98 deleted the python-linkage branch April 3, 2020 09:11
@lock lock bot added the outdated PR was locked due to age label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants