Skip to content

formula_cellar_checks: skip unless Python libs#7273

Merged
Bo98 merged 1 commit intoHomebrew:masterfrom
jonchang:python-cellar-build-deps
Apr 4, 2020
Merged

formula_cellar_checks: skip unless Python libs#7273
Bo98 merged 1 commit intoHomebrew:masterfrom
jonchang:python-cellar-build-deps

Conversation

@jonchang
Copy link
Copy Markdown
Contributor

@jonchang jonchang commented Apr 4, 2020

This avoids an unusual error message when Python is needed for building (e.g., code generation) and files are installed to lib but Python is not used at runtime.

Needed for https://github.com/Homebrew/linuxbrew-core/pull/19996

==> brew audit recode --online
Error: 1 problem in 1 formula detected
recode:
  * Packages have been installed for:

    but this formula depends on:
      Python 3.7

Because build-time dependencies are uninstalled on test-bot, this audit shouldn't be triggered as no Python libraries are actually installed to lib.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This avoids an unusual error message when Python is needed for building
(e.g., code generation) but is not used at runtime.

```
==> brew audit recode --online
Error: 1 problem in 1 formula detected
recode:
  * Packages have been installed for:

    but this formula depends on:
      Python 3.7
```
Copy link
Copy Markdown
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense - my bad. Thanks!

@Bo98 Bo98 merged commit 24adf6a into Homebrew:master Apr 4, 2020
@jonchang jonchang deleted the python-cellar-build-deps branch April 4, 2020 10:24
@jonchang
Copy link
Copy Markdown
Contributor Author

jonchang commented Apr 4, 2020

Thanks @Bo98!

@lock lock bot added the outdated PR was locked due to age label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants