utils/gems: prioritise Homebrew's chosen Ruby#7284
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Apr 5, 2020
Merged
utils/gems: prioritise Homebrew's chosen Ruby#7284MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Conversation
MikeMcQuaid
approved these changes
Apr 5, 2020
Member
|
Makes sense, thanks @Bo98. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?As seen in #5561 (comment), Ruby in other locations like rbenv may be used when installing gems. At the very least, this can mean installing native extensions to a place that won't match what Homebrew's chosen Ruby actually uses. At worst, we get hard to debug errors.
The reason other Rubys were being picked was because
~/.gem/2.6.0/binwas prioritised over Homebrew's chosen Ruby bin directory. This may mean that~/.gem/2.6.0/bin/bundleis run instead.This is a separate issue to the
TMPDIRone.