Skip to content

download_strategy: unlink the lock file after unlocking it#7293

Merged
dawidd6 merged 1 commit intoHomebrew:masterfrom
dawidd6:unlink-lock-file
Apr 6, 2020
Merged

download_strategy: unlink the lock file after unlocking it#7293
dawidd6 merged 1 commit intoHomebrew:masterfrom
dawidd6:unlink-lock-file

Conversation

@dawidd6
Copy link
Copy Markdown
Contributor

@dawidd6 dawidd6 commented Apr 6, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR solves the issue, where .incomplete.lock files are added to the bottle (oddly only on Linux).

Test subject brew install --build-bottle neofetch:

  • before patch
root@943ff26116de:/home/linuxbrew# brew ls -v neofetch
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/INSTALL_RECEIPT.json
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/LICENSE.md
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/bin/neofetch
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/.brew/neofetch.rb
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/README.md
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/.bottle/var/homebrew/locks/24736b4782b7372003a40fe3f994747e4c3a6fafbc4c5f7a8c5c5dbed58ebb0a--neofetch-7.0.0.tar.gz.incomplete.lock
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/share/man/man1/neofetch.1
  • after patch
root@d81b4d2a97a0:/home/linuxbrew# brew ls -v neofetch
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/INSTALL_RECEIPT.json
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/LICENSE.md
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/bin/neofetch
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/.brew/neofetch.rb
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/README.md
/home/linuxbrew/.linuxbrew/Cellar/neofetch/7.0.0/share/man/man1/neofetch.1

@MikeMcQuaid
Copy link
Copy Markdown
Member

Makes sense, thanks @dawidd6!

@dawidd6 dawidd6 merged commit 842d92a into Homebrew:master Apr 6, 2020
@dawidd6 dawidd6 deleted the unlink-lock-file branch April 6, 2020 08:29
@lock lock bot added the outdated PR was locked due to age label May 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants