Skip to content

docs/Formula-Cookbook.md: mention the use of 'bottle :unneeded'#7304

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
Moisan:bottle_unneeded_doc
Apr 8, 2020
Merged

docs/Formula-Cookbook.md: mention the use of 'bottle :unneeded'#7304
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
Moisan:bottle_unneeded_doc

Conversation

@Moisan
Copy link
Copy Markdown
Member

@Moisan Moisan commented Apr 8, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Based on @Bo98 comments on a recent PR, I added a short mention of bottle :unneeded in the Formula-Cookbook since it wasn't present in the docs.

Comment thread docs/Formula-Cookbook.md Outdated
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
@MikeMcQuaid MikeMcQuaid merged commit ddda67b into Homebrew:master Apr 8, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @Moisan!

@lock lock bot added the outdated PR was locked due to age label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants