Skip to content

ENV/std: restore original make_jobs return type#7307

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:make_jobs
Apr 9, 2020
Merged

ENV/std: restore original make_jobs return type#7307
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:make_jobs

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Apr 8, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This previously returned an integer and there is code which relies on this. (https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/60693/version=mojave/console)

The superenv version of make_jobs worked differently and still returns an integer.

The superenv-specific determine_make_jobs is probably not a concern. It could potentially even be removed entirely and its implementation inlined.

@MikeMcQuaid MikeMcQuaid merged commit 3146258 into Homebrew:master Apr 9, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @Bo98!

@Bo98 Bo98 deleted the make_jobs branch April 9, 2020 09:20
@lock lock bot added the outdated PR was locked due to age label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants