Skip to content

Fix KegOnlyReason property access.#7337

Merged
issyl0 merged 1 commit intoHomebrew:masterfrom
difelice:patch-1
Apr 12, 2020
Merged

Fix KegOnlyReason property access.#7337
issyl0 merged 1 commit intoHomebrew:masterfrom
difelice:patch-1

Conversation

@difelice
Copy link
Copy Markdown
Contributor

@difelice difelice commented Apr 12, 2020

Looks like a typo from previous commit.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

difelice referenced this pull request Apr 12, 2020
@MikeMcQuaid
cmd/link: don't link shadowed macOS software.
7f32e23
@dawidd6 dawidd6 changed the title Fix KeyOnlyReason property access. Fix KegOnlyReason property access. Apr 12, 2020
issyl0
issyl0 approved these changes Apr 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, @difelice! I've confirmed that this fixes #7339. Thanks so much for your first contribution to Homebrew! 💪

@issyl0 issyl0 merged commit 9e4dfaf into Homebrew:master Apr 12, 2020
This was referenced Apr 12, 2020
Closed
Closed
@difelice
Copy link
Copy Markdown
Contributor Author

difelice commented Apr 13, 2020

Thank-you!

@Zymergen-nkitagawa Zymergen-nkitagawa mentioned this pull request Apr 13, 2020
Merged
4 tasks
@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Apr 13, 2020

Ooops, thanks for the quick fix @difelice!

@difelice
Copy link
Copy Markdown
Contributor Author

difelice commented Apr 13, 2020

Ooops, thanks for the quick fix @difelice!

I'm glad to help. Thank you all!

@lock lock bot added the outdated PR was locked due to age label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@issyl0 issyl0 issyl0 approved these changes

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@difelice @MikeMcQuaid @issyl0