Skip to content

audit: fix keg_only check#7342

Merged
jonchang merged 1 commit intoHomebrew:masterfrom
jonchang:fix-audit
Apr 13, 2020
Merged

audit: fix keg_only check#7342
jonchang merged 1 commit intoHomebrew:masterfrom
jonchang:fix-audit

Conversation

@jonchang
Copy link
Copy Markdown
Contributor

@jonchang jonchang commented Apr 13, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #7341

Before this patch:

% brew audit --strict --new-formula xsimd   
Error: undefined method `provided_by_macos?' for nil:NilClass
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:406:in `block (2 levels) in audit_deps'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/delegate.rb:349:in `each'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/delegate.rb:349:in `block in delegating_block'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:378:in `block in audit_deps'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:375:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:375:in `audit_deps'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:1017:in `block in audit'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:1010:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:1010:in `audit'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:117:in `block in audit'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:110:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:110:in `audit'
/usr/local/Homebrew/Library/Homebrew/brew.rb:110:in `<main>'

After this patch:

% brew audit --strict --new-formula xsimd
xsimd:
  * New formulae in homebrew/core should not have a `bottle do` block
Error: 1 problem in 1 formula detected

@jonchang jonchang merged commit a2e1629 into Homebrew:master Apr 13, 2020
@jonchang jonchang deleted the fix-audit branch April 13, 2020 07:16
@MikeMcQuaid
Copy link
Copy Markdown
Member

Oops, thanks for quick fix @jonchang.

@lock lock bot added the outdated PR was locked due to age label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: undefined method `provided_by_macos?' for nil:NilClass on brew audit

2 participants