bump-revision: fixes for new style and license dsl#8139
Merged
Rylan12 merged 2 commits intoHomebrew:masterfrom Jul 30, 2020
Rylan12:bump-revision-fix
Merged
bump-revision: fixes for new style and license dsl#8139Rylan12 merged 2 commits intoHomebrew:masterfrom Rylan12:bump-revision-fix
Rylan12 merged 2 commits intoHomebrew:masterfrom
Rylan12:bump-revision-fix
Conversation
Allowing multiple licenses meant that `formula.license` returned an array. This converts that array to the appropriate format for `bump-revision`
3 tasks
MikeMcQuaid
approved these changes
Jul 30, 2020
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Assuming you've tested locally for both paths and it works as expected:
! Thanks @Rylan12!
Member
Author
|
I think I've covered everything:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?After #7953,
formula.licensereturns an array even when only one license is specified. This PR adds logic to check whether there is more than one license and formats thelicenseline appropriately.Additionally, #7867 changed the style for
revisionfrom:revision => "..."torevision: "...". This PR also handles that.