bump-formula-pr: add args to check_all_pull_requests#8169
Merged
dawidd6 merged 1 commit intoHomebrew:masterfrom Aug 1, 2020
Rylan12:bump-formula-pr-args
Merged
bump-formula-pr: add args to check_all_pull_requests#8169dawidd6 merged 1 commit intoHomebrew:masterfrom Rylan12:bump-formula-pr-args
dawidd6 merged 1 commit intoHomebrew:masterfrom
Rylan12:bump-formula-pr-args
Conversation
dawidd6
approved these changes
Aug 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?Follow up to #8144.
In #8144, the
args:parameter was added to most methods inbump-formula-pr.check_all_pull_requestswas missed, causing arguments to not be passed correctly.Example
Setup
Checkout Homebrew/homebrew-core@731f2b1
Before this PR
Even though
-fwas passedAfter this PR
Works as expected