Skip to content

bump-formula-pr: add args to check_all_pull_requests#8169

Merged
dawidd6 merged 1 commit intoHomebrew:masterfrom
Rylan12:bump-formula-pr-args
Aug 1, 2020
Merged

bump-formula-pr: add args to check_all_pull_requests#8169
dawidd6 merged 1 commit intoHomebrew:masterfrom
Rylan12:bump-formula-pr-args

Conversation

@Rylan12
Copy link
Copy Markdown
Member

@Rylan12 Rylan12 commented Aug 1, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow up to #8144.

In #8144, the args: parameter was added to most methods in bump-formula-pr. check_all_pull_requests was missed, causing arguments to not be passed correctly.

Example

Setup

Checkout Homebrew/homebrew-core@731f2b1

$ cd $(brew --repository homebrew/core)
$ git checkout 731f2b10fb01d715688f04f1cdc6c28adeb7f174 && git switch -c test

Before this PR

$ brew bump-formula-pr -nwf dxpy --url https://files.pythonhosted.org/packages/27/0d/4849e89891e1dc49681018d203b736073919dd9933738d78487a70e341d8/dxpy-0.298.1.tar.gz
Error: These pull requests may be duplicates:
dxpy 0.298.1 https://github.com/Homebrew/homebrew-core/pull/58880
Duplicate PRs should not be opened. Use --force to override this error.

Even though -f was passed

After this PR

$ brew bump-formula-pr -nwf dxpy --url https://files.pythonhosted.org/packages/27/0d/4849e89891e1dc49681018d203b736073919dd9933738d78487a70e341d8/dxpy-0.298.1.tar.gz
Warning: These pull requests may be duplicates:
dxpy 0.298.1 https://github.com/Homebrew/homebrew-core/pull/58880
==> Downloading https://files.pythonhosted.org/packages/27/0d/4849e89891e1dc49681018d203b736073919dd9933738d78487a70e341d8/dxpy-0.298.1.tar.gz
Already downloaded: /Users/rylanpolster/Library/Caches/Homebrew/downloads/efb31e8178325f50b7dc555b0ae8be6c0f75ea22b5a08d72d6ecc844165043bd--dxpy-0.298.1.tar.gz
Warning: Cannot verify integrity of efb31e8178325f50b7dc555b0ae8be6c0f75ea22b5a08d72d6ecc844165043bd--dxpy-0.298.1.tar.gz
A checksum was not provided for this resource.
For your reference the SHA-256 is: 280fe87450d0357d7d677c3732ac2a95b2ec7364cd6bea19db1f92738c1bdd37
==> replace /https:\/\/files\.pythonhosted\.org\/packages\/3d\/1a\/46c00205e2ee4d01e3d923c838f1b770b9af09f4147a4cd3e3dad1102b8b\/dxpy\-0\.297\.1\.tar\.gz/ wit==> replace "7cc680c5e2f44b80fb6ffd392eaffafd8b6ade722bf7e5c8d253c389b6602a64" with "280fe87450d0357d7d677c3732ac2a95b2ec7364cd6bea19db1f92738c1bdd37"
==> brew update-python-resources dxpy
...

Works as expected

@dawidd6 dawidd6 merged commit ad4d2ac into Homebrew:master Aug 1, 2020
@Rylan12 Rylan12 deleted the bump-formula-pr-args branch August 1, 2020 06:40
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants