Skip to content

style: autocorrect readthedocs and GitHub .git homepages#8213

Merged
dtrodrigues merged 1 commit intoHomebrew:masterfrom
dtrodrigues:homepage-style
Aug 4, 2020
Merged

style: autocorrect readthedocs and GitHub .git homepages#8213
dtrodrigues merged 1 commit intoHomebrew:masterfrom
dtrodrigues:homepage-style

Conversation

@dtrodrigues
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Read the Docs sites are hosted on .io and not .org: https://blog.readthedocs.com/securing-subdomains/
.git on GitHub refers to the git repository, not the homepage

We should flag (and possibly autocorrect) these homepage URLs during style checks.

@dtrodrigues
Copy link
Copy Markdown
Member Author

Test failure is expected, will re-run CI after Homebrew/homebrew-core#59138 is merged into hombrew-core and then linuxbrew-core.

@dtrodrigues dtrodrigues merged commit e76cea1 into Homebrew:master Aug 4, 2020
Comment thread Library/Homebrew/rubocops/homepage.rb
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 20, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants