Fix “wrong number of arguments” error#8243
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Aug 7, 2020
claui:fix-reinstall-restore-backup
Merged
Fix “wrong number of arguments” error#8243MikeMcQuaid merged 1 commit intoHomebrew:masterfrom claui:fix-reinstall-restore-backup
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
claui:fix-reinstall-restore-backup
Conversation
This commit fixes an error introduced in 6c964d4, which would surface on certain install/reinstall/upgrade failures. Example: ``` ==> Patching patching file default_out.txt Hunk #2 FAILED at 11. 1 out of 2 hunks FAILED -- saving rejects to file default_out.txt.rej Error: wrong number of arguments (given 3, expected 2) /usr/local/Homebrew/Library/Homebrew/reinstall.rb:77:in `restore_backup' /usr/local/Homebrew/Library/Homebrew/reinstall.rb:52:in `block in reinstall_formula' /usr/local/Homebrew/Library/Homebrew/utils.rb:377:in `ignore_interrupts' /usr/local/Homebrew/Library/Homebrew/reinstall.rb:52:in `rescue in reinstall_formula' /usr/local/Homebrew/Library/Homebrew/reinstall.rb:10:in `reinstall_formula' /usr/local/Homebrew/Library/Homebrew/cmd/reinstall.rb:71:in `block in reinstall' /usr/local/Homebrew/Library/Homebrew/cmd/reinstall.rb:65:in `each' /usr/local/Homebrew/Library/Homebrew/cmd/reinstall.rb:65:in `reinstall' /usr/local/Homebrew/Library/Homebrew/brew.rb:112:in `<main>' ```
Member
|
Thanks @claui! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally? Seven failing tests locally but none of them seem related.This PR fixes an error introduced in #8187, which would surface on certain
brew install/brew reinstall/brew upgradefailures.Example: