Skip to content

Fix --formula and --cask flags.#8245

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:fix-formula-cask-flags
Aug 7, 2020
Merged

Fix --formula and --cask flags.#8245
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:fix-formula-cask-flags

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

These were all made --formulae and --casks for consistency but that doesn't behave as expected because they have special behaviours in args. Instead, use the singular form everywhere.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

These were all made `--formulae` and `--casks` for consistency but that
doesn't behave as expected because they have special behaviours in
`args`. Instead, use the singular form everywhere.
@MikeMcQuaid MikeMcQuaid merged commit e4c9f76 into Homebrew:master Aug 7, 2020
@MikeMcQuaid MikeMcQuaid deleted the fix-formula-cask-flags branch August 7, 2020 09:25
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 20, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants