Use the latest Sorbet version and regenerate Tapioca RBIs#8267
Merged
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom Aug 10, 2020
Merged
Conversation
- This was originally pinned in 1a6467e because we found that later versions surfaced over 100 new typing errors in Tapioca's autogenerated RBI files. It seems like these are able to be fixed now.
- [The docs](https://sorbet.org/docs/rbi#the-hidden-definition-rbi) say we have to do this whenever gems are bumped.
Contributor
|
Tested this as well. Works well for me! |
Member
It could do but would probably make more sense to put it in the repository root. |
Member
|
Let's prioritise ASAP getting a CI job step that tests something that will fail if a newer version of sorbet goes 💥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?bundle exec srb tc: 13 errors.bundle exec srb tc --typed-override=sorbet/files.yaml: 18 errors.(cc @vidusheeamoli, @mistydemeo)
I have a question about the Ruby version mismatch: should
Library/Homebrewhave a.ruby-versionfile so thatrbenvcan use the correct Ruby version automatically rather than defaulting to the global one?