Skip to content

Use the latest Sorbet version and regenerate Tapioca RBIs#8267

Merged
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom
issyl0:use-latest-sorbet-and-regenerate-tapioca-rbis
Aug 10, 2020
Merged

Use the latest Sorbet version and regenerate Tapioca RBIs#8267
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom
issyl0:use-latest-sorbet-and-regenerate-tapioca-rbis

Conversation

@issyl0
Copy link
Copy Markdown
Member

@issyl0 issyl0 commented Aug 9, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • The Sorbet version was originally pinned in 1a6467e because we found that newer versions surfaced over 100 new typing errors in Tapioca's autogenerated RBI files. If we remove and entirely regenerate (using Ruby 2.6.3, not Ruby 2.7), as opposed to resync the Tapioca RBIs, these errors go away.
  • Current errors status report, using Ruby 2.6.3 and Sorbet 0.5.5866:
    • bundle exec srb tc: 13 errors.
    • bundle exec srb tc --typed-override=sorbet/files.yaml: 18 errors.
    • None of the errors are in RBI files. 🎉

(cc @vidusheeamoli, @mistydemeo)


I have a question about the Ruby version mismatch: should Library/Homebrew have a .ruby-version file so that rbenv can use the correct Ruby version automatically rather than defaulting to the global one?

issyl0 added 3 commits August 9, 2020 12:03
- This was originally pinned in 1a6467e
  because we found that later versions surfaced over 100 new typing errors
  in Tapioca's autogenerated RBI files. It seems like these are able to
  be fixed now.
- [The docs](https://sorbet.org/docs/rbi#the-hidden-definition-rbi) say
  we have to do this whenever gems are bumped.
@vidusheeamoli
Copy link
Copy Markdown
Contributor

Tested this as well. Works well for me!

@MikeMcQuaid
Copy link
Copy Markdown
Member

I have a question about the Ruby version mismatch: should Library/Homebrew have a .ruby-version file so that rbenv can use the correct Ruby version automatically rather than defaulting to the global one?

It could do but would probably make more sense to put it in the repository root.

@MikeMcQuaid MikeMcQuaid merged commit db11d5e into Homebrew:master Aug 10, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Let's prioritise ASAP getting a CI job step that tests something that will fail if a newer version of sorbet goes 💥

@issyl0 issyl0 deleted the use-latest-sorbet-and-regenerate-tapioca-rbis branch August 10, 2020 10:15
@issyl0 issyl0 mentioned this pull request Aug 10, 2020
6 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 19, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants