Skip to content

Refactor and document Version.#8350

Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:doc-version
Aug 26, 2020
Merged

Refactor and document Version.#8350
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:doc-version

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

@reitermarkus reitermarkus commented Aug 14, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Extracted from #8339 for easier review.

Comment thread Library/.rubocop.yml Outdated
Comment thread Library/Homebrew/version.rb Outdated
@reitermarkus reitermarkus merged commit 5cd8b60 into Homebrew:master Aug 26, 2020
@reitermarkus reitermarkus deleted the doc-version branch August 26, 2020 07:09
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 15, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants