Skip to content

Consistently use HOMEBREW_RUBY_WARNINGS when calling ruby#8407

Merged
dawidd6 merged 1 commit intoHomebrew:masterfrom
dawidd6:ruby-w0
Aug 20, 2020
Merged

Consistently use HOMEBREW_RUBY_WARNINGS when calling ruby#8407
dawidd6 merged 1 commit intoHomebrew:masterfrom
dawidd6:ruby-w0

Conversation

@dawidd6
Copy link
Copy Markdown
Contributor

@dawidd6 dawidd6 commented Aug 20, 2020

This allows us to suppress warnings like:

/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/language/python.rb:8: warning: Insecure world writable dir /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/scm in PATH, mode 040777

Same option is passed in dev-cmd/test.rb:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Comment thread Library/Homebrew/dev-cmd/ruby.rb Outdated
Adding this in `dev-cmd/ruby.rb` allows us to suppress warnings like:
```
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/language/python.rb:8: warning: Insecure world writable dir /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/scm in PATH, mode 040777
```
@dawidd6 dawidd6 changed the title dev-cmd/ruby: pass -W0 to ruby executable Consistently use HOMEBREW_RUBY_WARNINGS when calling ruby Aug 20, 2020
@dawidd6 dawidd6 merged commit ebafc70 into Homebrew:master Aug 20, 2020
@dawidd6 dawidd6 deleted the ruby-w0 branch August 20, 2020 19:38
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants