Consistently use HOMEBREW_RUBY_WARNINGS when calling ruby#8407
Merged
dawidd6 merged 1 commit intoHomebrew:masterfrom Aug 20, 2020
Merged
Consistently use HOMEBREW_RUBY_WARNINGS when calling ruby#8407dawidd6 merged 1 commit intoHomebrew:masterfrom
dawidd6 merged 1 commit intoHomebrew:masterfrom
Conversation
MikeMcQuaid
reviewed
Aug 20, 2020
Adding this in `dev-cmd/ruby.rb` allows us to suppress warnings like: ``` /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/language/python.rb:8: warning: Insecure world writable dir /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/scm in PATH, mode 040777 ```
-W0 to ruby executable
MikeMcQuaid
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to suppress warnings like:
Same option is passed in
dev-cmd/test.rb:brew/Library/Homebrew/dev-cmd/test.rb
Line 81 in 8041649
brew stylewith your changes locally?brew testswith your changes locally?