Skip to content

cmd/update-report: fix output of new casks#8409

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
miccal:cask_new_fix
Aug 20, 2020
Merged

cmd/update-report: fix output of new casks#8409
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
miccal:cask_new_fix

Conversation

@miccal
Copy link
Copy Markdown
Contributor

@miccal miccal commented Aug 20, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

In a recent PR I added an output for "New Casks" to brew update, like so:

==> New Casks
a_shiny_new_cask

However, after merging I noticed that the output was actually being shown as follows:

==> New Casks
homebrew/cask/a_shiny_new_cask

This trivial change fixes this oversight.

Apologies for missing this in my original PR.

Thank you.

@MikeMcQuaid MikeMcQuaid merged commit 6cde372 into Homebrew:master Aug 20, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @miccal!

@miccal
Copy link
Copy Markdown
Contributor Author

miccal commented Aug 20, 2020

No problem @MikeMcQuaid, sorry for the silly error on my part.

@miccal miccal deleted the cask_new_fix branch August 20, 2020 13:08
@MikeMcQuaid
Copy link
Copy Markdown
Member

@miccal I'll accept your apology when you're made more than me (which will take you a long time) 😂

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants