cli/named_args: Print correct cask ref when name is loaded as formula/keg#8483
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Aug 27, 2020
Merged
Conversation
whoiswillma
changed the title
whoiswillma
changed the title
Contributor
maxim-belkin
left a comment
maxim-belkin
left a comment
There was a problem hiding this comment.
- Changes make sense to me.
- I'm not sure
puts_treatment_...is the best name. Perhaps someone could suggest a better alternative. - I'm not sure that
Cask::CaskUnavailableErrorshould be ignored.
whoiswillma
force-pushed
the
print-correct-cask-ref
branch
from
8636541 to
d32be75
Compare
maxim-belkin
approved these changes
Aug 25, 2020
Contributor
maxim-belkin
left a comment
maxim-belkin
left a comment
There was a problem hiding this comment.
Makes sense to me 👍
Contributor
Author
|
What's up with CI? The tests are passing on my local machine, and it seems the failure is unrelated to the changes I've made? |
Contributor
Error message: https://github.com/Homebrew/brew/pull/8483/checks?check_run_id=1027387423#step:13:79 Perhaps related to 6776000 |
MikeMcQuaid
approved these changes
Aug 27, 2020
Member
|
Nice work again @whoiswillma! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?Fix a bug where the wrong ref was printed for a cask from a third-party tap with the same name as a formula.
To recreate:
whoiswillma/caskhomebrew/cask/crunch.rbtowhoiswillma/cask,whoiswillma/cask/crunchtogifskior some other formulabrew home gifski, which printsTreating gifski as a formula. For the cask, use homebrew/cask/gifski, when the correct ref should bewhoiswillma/cask/gifski.