Fix unvendored RubyGems#8511
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Aug 27, 2020
MikeMcQuaid:fix-gems
Merged
Fix unvendored RubyGems#8511MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:fix-gems
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:fix-gems
Conversation
- Avoid caching RubyGems in GitHub Actions `tests.yml` to catch this in future. - Run `brew doctor` in GitHub Actions `tests.yml` after installing RubyGems to catch this in future. - Ignore relevant RubyGems (and fix outdated comments) - Never auto-`require` RubyGems that aren't vendored. - Update `bundler/setup.rb`.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests.ymlto catch this infuture.
brew doctorin GitHub Actionstests.ymlafter installingRubyGems to catch this in future.
requireRubyGems that aren't vendored.bundler/setup.rb.Alternate approach to #8508
Fixes #8503 (comment)
brew stylewith your changes locally?brew testswith your changes locally?