Skip to content

Fix unvendored RubyGems#8511

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:fix-gems
Aug 27, 2020
Merged

Fix unvendored RubyGems#8511
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:fix-gems

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

  • Avoid caching RubyGems in GitHub Actions tests.yml to catch this in
    future.
  • Run brew doctor in GitHub Actions tests.yml after installing
    RubyGems to catch this in future.
  • Ignore relevant RubyGems (and fix outdated comments)
  • Never auto-require RubyGems that aren't vendored.
  • Update bundler/setup.rb.

Alternate approach to #8508
Fixes #8503 (comment)


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

- Avoid caching RubyGems in GitHub Actions `tests.yml` to catch this in
  future.
- Run `brew doctor` in GitHub Actions `tests.yml` after installing
  RubyGems to catch this in future.
- Ignore relevant RubyGems (and fix outdated comments)
- Never auto-`require` RubyGems that aren't vendored.
- Update `bundler/setup.rb`.
@MikeMcQuaid MikeMcQuaid merged commit 435ff54 into Homebrew:master Aug 27, 2020
@MikeMcQuaid MikeMcQuaid deleted the fix-gems branch August 27, 2020 13:27
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 15, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants