rubocops/patches: GitHub/GitLab patches should end with .patch

[SeekingMeaning]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

See discussion below

Old description

GitLab doesn't support ?full_index=1 for patch URLs, but instead we can use .diff to get full indices. This PR adds a check for GitLab patches ending with .patch that will be reported by brew audit

brew audit gstreamer:

gstreamer:
  * C: 33: col 10: GitLab patches should end with .diff, not .patch:
      https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/40c994cddee41954053f80dde40f56107ddfcfd4.patch
Error: 1 problem in 1 formula detected

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/40c994c.patch (short indices):

index eefe1c9d646..4370acd9562 100755

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/40c994c.diff (full indices):

index eefe1c9d646d81fc0f09a81e11482449f4f4e144..4370acd956210fe23abea91da162f0aa6c02e26f 100755

[MikeMcQuaid]

Have this broken recently/before? The patch is slightly preferable, in my book, due to the increased metadata.

[SeekingMeaning]

Have this broken recently/before?

No

The patch is slightly preferable, in my book, due to the increased metadata.

I think it's okay to not have the patch metadata since we already usually add a comment to the merge request, for example: https://github.com/Homebrew/homebrew-core/blob/b599f82/Formula/gstreamer.rb#L31

Although, I'm fine with enforcing .patch instead — currently we're using a mix of both .patch and .diff in homebrew/core

[MikeMcQuaid]

Although, I'm fine with enforcing .patch instead — currently we're using a mix of both .patch and .diff in homebrew/core

👍🏻 I'm OK with that, I don't feel strongly either way but I would also like to have them be consistent.

[claui]

I think it's okay to not have the patch metadata since we already usually add a comment to the merge request

Metadata can be important when backporting multi-commit patches (example).

However, those are rare, plus they typically go on formula-patches. LGTM 👍

[SeekingMeaning]

Currently failing because of existing patches ending with .diff — would it be acceptable to change these to .patch as CI-syntax-only changes?

[MikeMcQuaid]

Yes please @SeekingMeaning!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[jonchang]

Gonna merge this since the last stragglers have been fixed on both macOS and Linux. Thanks @SeekingMeaning!

[fxcoudert]

This means that if we're re-running old workflows, we get tons of errors unrelated to the pull request being tested: https://github.com/Homebrew/homebrew-core/pull/62208/checks?check_run_id=1297673335

Could this be avoided?