Skip to content

bump-formula-pr: exit with error if formula is disabled#8733

Merged
SeekingMeaning merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:bump-formula-pr/disabled-formula
Sep 15, 2020
Merged

bump-formula-pr: exit with error if formula is disabled#8733
SeekingMeaning merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:bump-formula-pr/disabled-formula

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

@SeekingMeaning SeekingMeaning commented Sep 15, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This prevents bump PRs from being created for disabled formulae

Related: Homebrew/homebrew-core#61173, Homebrew/homebrew-core#60767

@SeekingMeaning SeekingMeaning merged commit b46025f into Homebrew:master Sep 15, 2020
@SeekingMeaning SeekingMeaning deleted the bump-formula-pr/disabled-formula branch September 15, 2020 22:10
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants