test/language/java_spec: drop version to 1.6+#8751
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Sep 17, 2020
miccal:java-spec
Merged
test/language/java_spec: drop version to 1.6+#8751MikeMcQuaid merged 1 commit intoHomebrew:masterfrom miccal:java-spec
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
miccal:java-spec
Conversation
MikeMcQuaid
approved these changes
Sep 17, 2020
Member
|
Seems fair, thanks @miccal! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?On one of my Mac machines I use an app that (still!) works best with the legacy Java 6 provided by Apple.
This is the only version of Java I have on this machine:
However, having this version causes
brew teststo (correctly) fail:Changing the minimum version on
java_spec.rbto1.6+fixes this error:I know this is a very old version fo Java, but it is still provided by Apple, hence this PR.
Please feel free to reject this PR if this change would cause other issues that I may not be aware of.
Thank you.