Skip to content

dev-cmd/pr-pull: refactor and add tests#8754

Merged
jonchang merged 9 commits intoHomebrew:masterfrom
jonchang:refactor-git-cmds
Sep 21, 2020
Merged

dev-cmd/pr-pull: refactor and add tests#8754
jonchang merged 9 commits intoHomebrew:masterfrom
jonchang:refactor-git-cmds

Conversation

@jonchang
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Continuation of #8724

@jonchang jonchang changed the title dev-cmd/pr-pull: move functions into utils/ dev-cmd/pr-pull: move functions into utils Sep 19, 2020
@jonchang jonchang changed the title dev-cmd/pr-pull: move functions into utils dev-cmd/pr-pull: refactor and add tests Sep 20, 2020
@jonchang jonchang requested a review from a team September 20, 2020 04:05
@jonchang jonchang marked this pull request as ready for review September 20, 2020 04:05
@jonchang
Copy link
Copy Markdown
Contributor Author

Ok, this is ready for review. I've structured this pull request so each commit can be looked at in isolation, if desired.

@jonchang jonchang merged commit e082da4 into Homebrew:master Sep 21, 2020
@jonchang
Copy link
Copy Markdown
Contributor Author

Thanks for the 👀

@jonchang jonchang deleted the refactor-git-cmds branch September 21, 2020 08:59
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants