Skip to content

tap: remove redundant exception.#8825

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
MikeMcQuaid:tap-redundant-exception
Sep 30, 2020
Merged

tap: remove redundant exception.#8825
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
MikeMcQuaid:tap-redundant-exception

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Sep 30, 2020

Don't raise an exception only to catch it.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@MikeMcQuaid MikeMcQuaid merged commit cac8e7a into Homebrew:master Sep 30, 2020
@MikeMcQuaid MikeMcQuaid deleted the tap-redundant-exception branch September 30, 2020 16:14
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants