Skip to content

pr-upload: add --no-commit flag#8847

Merged
jonchang merged 1 commit intoHomebrew:masterfrom
Rylan12:pr-upload-add-no-commit-flag
Oct 3, 2020
Merged

pr-upload: add --no-commit flag#8847
jonchang merged 1 commit intoHomebrew:masterfrom
Rylan12:pr-upload-add-no-commit-flag

Conversation

@Rylan12
Copy link
Copy Markdown
Member

@Rylan12 Rylan12 commented Oct 3, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Allow pr-upload to run without committing changes

This is useful in a few special cases (such as Homebrew/homebrew-core#62022) where the bottle upload failed but the bottle commit made it into master. Now, running brew pr-upload --no-commit in the bottle directory will upload the bottles without trying to generate a new bottle commit.

The current alternative is to check out a commit before the bottle commit, run pr-pull, and then reset to origin/master. This situation is rare enough that using that workflow isn't terrible, but here's a potential quick fix to make it even easier.

CC @jonchang

@jonchang
Copy link
Copy Markdown
Contributor

jonchang commented Oct 3, 2020

LGTM. Thanks for updating the docs too!

@jonchang jonchang merged commit cda13d1 into Homebrew:master Oct 3, 2020
@Rylan12 Rylan12 deleted the pr-upload-add-no-commit-flag branch October 3, 2020 17:45
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants