pr-upload: add --no-commit flag#8847
Merged
jonchang merged 1 commit intoHomebrew:masterfrom Oct 3, 2020
Rylan12:pr-upload-add-no-commit-flag
Merged
pr-upload: add --no-commit flag#8847jonchang merged 1 commit intoHomebrew:masterfrom Rylan12:pr-upload-add-no-commit-flag
jonchang merged 1 commit intoHomebrew:masterfrom
Rylan12:pr-upload-add-no-commit-flag
Conversation
Contributor
|
LGTM. Thanks for updating the docs too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?Allow
pr-uploadto run without committing changesThis is useful in a few special cases (such as Homebrew/homebrew-core#62022) where the bottle upload failed but the bottle commit made it into master. Now, running
brew pr-upload --no-commitin the bottle directory will upload the bottles without trying to generate a new bottle commit.The current alternative is to check out a commit before the bottle commit, run
pr-pull, and then reset toorigin/master. This situation is rare enough that using that workflow isn't terrible, but here's a potential quick fix to make it even easier.CC @jonchang