Skip to content

tab: fix nil modification time#8853

Merged
jonchang merged 2 commits intoHomebrew:masterfrom
jonchang:fix-nil-mtime
Oct 5, 2020
Merged

tab: fix nil modification time#8853
jonchang merged 2 commits intoHomebrew:masterfrom
jonchang:fix-nil-mtime

Conversation

@jonchang
Copy link
Copy Markdown
Contributor

@jonchang jonchang commented Oct 5, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Fixes #8840. It's unclear why the modification time of the staged tarball could ever be nil; I suspect there's a bug in downloader_strategy.rb, but without the ability to reproduce locally this workaround should suffice.

@jonchang jonchang merged commit 447302a into Homebrew:master Oct 5, 2020
@jonchang jonchang deleted the fix-nil-mtime branch October 5, 2020 03:28
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: can't convert nil into an exact number

2 participants