Skip to content

Refactor OS::Mac::Version.#8859

Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:macos-version
Oct 7, 2020
Merged

Refactor OS::Mac::Version.#8859
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:macos-version

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

@reitermarkus reitermarkus commented Oct 5, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Closes Homebrew/homebrew-cask#90326.

Comment thread Library/Homebrew/os/mac/sdk.rb Outdated
Comment thread Library/Homebrew/requirements/macos_requirement.rb Outdated
@reitermarkus reitermarkus merged commit ccb271b into Homebrew:master Oct 7, 2020
@reitermarkus reitermarkus deleted the macos-version branch October 7, 2020 10:18
@maraflush
Copy link
Copy Markdown

maraflush commented Oct 11, 2020

Hello your refactoring not working properly here. Since a week, homebrew seems work only with bottle but it not able to trigger the compiler like gcc or llvm. Just before to trigger gcc, the following exception is raised : "Array into Integer conversion", here @koenvd's fix seems not work.
Could you fix it, please.
Best regards,

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants