audit: check versioned dependency conflicts.#8884
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Oct 9, 2020
MikeMcQuaid:audit-versioned-conflicts
Merged
audit: check versioned dependency conflicts.#8884MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:audit-versioned-conflicts
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:audit-versioned-conflicts
Conversation
We don't want to have a formula depending on e.g. both `python@3.8` and `python@3.9` in the same dependency tree (generally). As this isn't a blanket rule: add an allowlist with the expectation that we'll need to use it.
MikeMcQuaid
commented
Oct 9, 2020
|
|
||
| # The number of conflicts on Linux is absurd. | ||
| # TODO: remove this and check these there too. | ||
| return if OS.linux? |
Member
Author
There was a problem hiding this comment.
CC @Homebrew/linux that I did this. Uncomment it and try it out to see for yourself 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to have a formula depending on e.g. both
python@3.8andpython@3.9in the same dependency tree (generally).As this isn't a blanket rule: add an allowlist with the expectation that we'll need to use it.
Note to self: check the
brew auditperformance and if it degrades much in CI by adding this.brew stylewith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?