Remove infrakit from GITHUB_PRERELEASE_ALLOWLIST as it's deprecated#8985
Merged
issyl0 merged 1 commit intoHomebrew:masterfrom Oct 25, 2020
Merged
Conversation
Member
|
The allow-list ends up being to synced with formulas because it's in a different repo. Wouldn't it be better to have a way maintain this information in the same place? I.e., in a given formula, tag it with “this is a prerelease but it's okay”? That way, when we update, we can check if it's still relevant — and it gets removed when the formula is deprecated or removed. |
fxcoudert
approved these changes
Oct 25, 2020
Member
Author
|
@fxcoudert Good point, yeah. There are other allowlists for other things to do with formulae too. We can have a think about how to handle it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you written new tests for your changes? Here's an example.Have you successfully runbrew stylewith your changes locally?Have you successfully runbrew testswith your changes locally?Have you successfully runbrew manlocally and committed any changes?