Skip to content

install: tweak missing formula behaviour.#8988

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:tweak-search
Oct 27, 2020
Merged

install: tweak missing formula behaviour.#8988
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:tweak-search

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Oct 26, 2020

  • Run brew search for local formulae first (as it's quickest) rather than checking Git history.
  • Don't output Searching taps... because Searching taps on GitHub... is output by the called function (and because it'll say it's searching taps even when it is not if HOMEBREW_NO_GITHUB_API is set).

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

- Run `brew search` for local formulae first (as it's quickest) rather
  than checking Git history.
- Don't output `Searching taps...` because `Searching taps on GitHub...`
  is output by the called function (and because it'll say it's searching
  taps even when it is not if `HOMEBREW_NO_GITHUB_API` is set).
@MikeMcQuaid MikeMcQuaid merged commit da71dde into Homebrew:master Oct 27, 2020
@MikeMcQuaid MikeMcQuaid deleted the tweak-search branch October 27, 2020 11:49
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants