Skip to content

Maintainer-Guidelines: give maintainers time to review enhancements. #8989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeMcQuaid merged 3 commits into from
Oct 29, 2020
Merged

Maintainer-Guidelines: give maintainers time to review enhancements. #8989

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f64e1fc
Maintainer-Guidelines: give maintainers time to review enhancements.
MikeMcQuaid Oct 26, 2020
2e957b2
Maintainer-Guidelines: note refactoring PR review.
MikeMcQuaid Oct 26, 2020
57e8f34
Maintainer-Guidelines: add homebrew-core 24h caveat.
MikeMcQuaid Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions docs/Maintainer-Guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,18 @@ Any maintainer can merge any PR they have carefully reviewed and is passing CI t

Any maintainer can revert a PR created by another maintainer after a user submitted issue or CI failure that results. The maintainer who created the original PR should be given no less than an hour to fix the issue themselves or decide to revert the PR themselves if they would rather.

### Give time for other maintainers to review

PRs that are an "enhancement" to existing functionality i.e. not a fix to an open user issue/discussion, not a version bump, not a security fix, not a fix for CI failure, a usability improvement, a new feature, refactoring etc. should wait 24h Monday - Friday before being merged. For example,

- a new feature PR submitted at 5pm on Thursday should wait until 5pm on Friday before it is merged
- a usability fix PR submitted at 5pm on Friday should wait until 5pm on Monday before it is merged
- a user-reported issue fix PR can be merged immediately after CI is green

If a maintainer is on holiday/vacation/sick during this time and leaves comments after they are back: please treat post-merge PR comments and feedback as you would left within the time period and follow-up with another PR to address their requests (if agreed).

The vast majority of Homebrew/homebrew-core PRs are bug fixes or version bumps so can be self-merged once CI has completed.

## Communication

Maintainers have a variety of ways to communicate with each other:
Expand Down