Skip to content

spec_helper: fix Timeout::Error/SystemExit handling.#9004

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:fix-timeout-exit-retry
Oct 29, 2020
Merged

spec_helper: fix Timeout::Error/SystemExit handling.#9004
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:fix-timeout-exit-retry

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Oct 29, 2020

These need to be manually caught and set otherwise they will not be retried by rspec-retry. This is particularly annoying and a cause of CI failures when tests timeout but are not retried.

Also, because timeouts should be rarer now, reduce the general timeout from 120s to 60s.

add468b is pushed temporarily (and should not be merged) to attempt to reproduce the correct behaviour on a forced timeout This has been removed due to reproduction in https://github.com/Homebrew/brew/pull/9004/checks?check_run_id=1326013554#step:13:38

Fixes #8979

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

These need to be manually caught and set otherwise they will not be
retried by `rspec-retry`. This is particularly annoying and a cause of
CI failures when tests timeout but are not retried.

Fixes #8979
@MikeMcQuaid
Copy link
Copy Markdown
Member Author

Confirmed from https://github.com/Homebrew/brew/pull/9004/checks?check_run_id=1326013554#step:13:38 that this is correctly retrying these examples now 🎉

@MikeMcQuaid MikeMcQuaid merged commit 63fc64a into Homebrew:master Oct 29, 2020
@MikeMcQuaid MikeMcQuaid deleted the fix-timeout-exit-retry branch October 29, 2020 11:41
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew CI has general failures

2 participants