spec_helper: fix Timeout::Error/SystemExit handling.#9004
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Oct 29, 2020
MikeMcQuaid:fix-timeout-exit-retry
Merged
spec_helper: fix Timeout::Error/SystemExit handling.#9004MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:fix-timeout-exit-retry
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:fix-timeout-exit-retry
Conversation
These need to be manually caught and set otherwise they will not be retried by `rspec-retry`. This is particularly annoying and a cause of CI failures when tests timeout but are not retried. Fixes #8979
Member
Author
|
Confirmed from https://github.com/Homebrew/brew/pull/9004/checks?check_run_id=1326013554#step:13:38 that this is correctly retrying these examples now 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These need to be manually caught and set otherwise they will not be retried by
rspec-retry. This is particularly annoying and a cause of CI failures when tests timeout but are not retried.Also, because timeouts should be rarer now, reduce the general timeout from 120s to 60s.
add468b is pushed temporarily (and should not be merged) to attempt to reproduce the correct behaviour on a forced timeoutThis has been removed due to reproduction in https://github.com/Homebrew/brew/pull/9004/checks?check_run_id=1326013554#step:13:38Fixes #8979
brew stylewith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?